Fix conversion of Zstd images to non-OCI formats #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures ... and rename local variables within the function to be a bit more explicit. Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
... to share the check that ensures the input hasn't been affected. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
For any Zstd layer, do a MIME type update (presumably converting from Zstd to something else) before we do the format conversion, so that the format conversion doesn't fail with an unsupported MIME type. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
vrothberg
approved these changes
Oct 20, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any Zstd layer, do a MIME type update (presumably converting from Zstd to something else) before we do the
format conversion, so that the format conversion doesn't fail with an unsupported MIME type.
Fixes #1260 .